Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update github login example #416

Merged
merged 2 commits into from Sep 13, 2019
Merged

Update github login example #416

merged 2 commits into from Sep 13, 2019

Conversation

Death-Gear
Copy link
Contributor

@Death-Gear Death-Gear commented Jul 25, 2019 •
edited

Proposed Changes

  • Added comment helping developers set up a github app for generating ID and secret
  • isSecure option added

Reasons

  • The comment can help users set up a github app.
  • isSecure must be set to false to remove the TLS requirement.

@hueniverse hueniverse self-assigned this Sep 13, 2019
@hueniverse hueniverse added this to the 11.0.0 milestone Sep 13, 2019
@hueniverse hueniverse merged commit 679287a into hapijs:master Sep 13, 2019
@Marsup Marsup added documentation Non-code related changes and removed example labels Sep 20, 2019
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@hueniverse hueniverse

Labels
documentation Non-code related changes
Projects
None yet
Milestone
11.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Death-Gear @hueniverse @Marsup